>From Hongyu Shi <[email protected]>:
Attention is currently required from: Hongyu Shi.
Hello Anon. E. Moose #1000171, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21650?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Contrib-2 by Anon. E. Moose #1000171, Integration-Tests+1 by Jenkins,
Verified-1 by Jenkins
Change subject: [ASTERIXDB-3760][RT] Report an unusable sample as a build
failure
......................................................................
[ASTERIXDB-3760][RT] Report an unusable sample as a build failure
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
When the sample yields no vector usable at the declared dimension, the
quantization stage has no constants to emit and the build cannot proceed.
Reporting that as ILLEGAL_STATE describes a broken invariant, when it is really
a property of the user's data and is reachable with a collection whose indexed
field is NULL in every record. A consumer that maps error codes to user-facing
ones deliberately leaves the internal-invariant codes unmapped, so it surfaced
as a bare "Internal error" with the explanation only in the server log. Report
it as VECTOR_INDEX_BUILD_FAILED instead, which the sibling throws in this class
and in VTreeStaticStructureBuilder and VTreeBulkLoader already use for the same
family of condition, and drop the payload byte count from the text because the
code already supplies "Failed to build the vector index". The two guards above
it stay ILLEGAL_STATE because a second tuple or a multi-tuple frame really is a
broken invariant.
Ext-ref: MB-73278, MB-73424
Co-Authored-By: Claude Opus 5 <[email protected]>
Change-Id: I6a3c11c1ac2d46c7a074a2ce01bcaeb570407ef1
---
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/vector/VectorQueries.xml
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/vector/create-index-vtree-null-embedding/create-index-vtree-null-embedding.01.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/vector/create-index-vtree-null-embedding/create-index-vtree-null-embedding.02.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/vector/create-index-vtree-null-embedding/create-index-vtree-null-embedding.03.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/vector/create-index-vtree-null-embedding/create-index-vtree-null-embedding.04.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/vector/create-index-vtree-null-embedding/create-index-vtree-null-embedding.99.ddl.sqlpp
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-vtree/src/main/java/org/apache/hyracks/storage/am/lsm/vector/dataflow/QuantizedIndexCreateOperatorDescriptor.java
7 files changed, 162 insertions(+), 6 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/50/21650/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21650?usp=email
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I6a3c11c1ac2d46c7a074a2ce01bcaeb570407ef1
Gerrit-Change-Number: 21650
Gerrit-PatchSet: 2
Gerrit-Owner: Hongyu Shi <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Attention: Hongyu Shi <[email protected]>
