>From Hongyu Shi <[email protected]>:
Attention is currently required from: Hongyu Shi.
Hello Anon. E. Moose #1000171, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21653?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Integration-Tests+1 by Jenkins, Verified-1 by Jenkins
Change subject: [ASTERIXDB-3817][COMP][RT] Add isVector() for embedding
validation
......................................................................
[ASTERIXDB-3817][COMP][RT] Add isVector() for embedding validation
- user model changes: yes
- storage format changes: no
- interface changes: yes
Details:
A usable embedding is a list of the expected length whose every element is
numeric. VectorValidator states that rule once for the whole engine. Elements
are inspected individually when the list's item type is ANY because a
heterogeneous list declares nothing about any particular element. isvector(v)
and isvector(v, dimension) surface the rule to SQL++ so that a user can ask
which records an index will skip. Null and missing propagate as they do for
is_array and the rest of the is_* family. A WHERE clause cannot tell either
apart from false. An empty list is never a vector because there is nothing to
index.
Ext-ref: MB-73666
Co-Authored-By: Claude Opus 5 <[email protected]>
Change-Id: I8631abc61ba7c15c53ec02ec5646d7bf92711eea
---
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isvector/isvector.1.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/types/isvector/isvector.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/sqlpp_queries.xml
M
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/CommonFunctionMapUtil.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
A
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/VectorValidator.java
A
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IsVectorDescriptor.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java
8 files changed, 333 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/53/21653/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21653?usp=email
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I8631abc61ba7c15c53ec02ec5646d7bf92711eea
Gerrit-Change-Number: 21653
Gerrit-PatchSet: 3
Gerrit-Owner: Hongyu Shi <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Attention: Hongyu Shi <[email protected]>
