>From Michael Blow <[email protected]>:
Attention is currently required from: Hussain Towaileb, Michael Blow.
Hello Hussain Towaileb,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21664?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Michael Blow, Code-Review+2 by Hussain Towaileb
Change subject: [NO ISSUE][TEST] Allow multiple test categories
......................................................................
[NO ISSUE][TEST] Allow multiple test categories
The category attribute of a test-case is single-valued and its only
value is "slow", so a case can be in at most one category. Two axes
already exist in practice, and a case may need to sit on both.
- make category a whitespace-separated list of category-enum, so a case
can declare category="slow requires-stable-topology"
- add requires-stable-topology and requires-default-frame-size, and say
in the schema what a category means: something a test needs from the
suite running it, so a suite that cannot provide it can leave the test
out. It is up to each consumer to decide which categories it honours;
the builder itself still honours only "slow"
- add TestCaseContext.hasCategory so a consumer need not reach through
getTestCase()
- reject an unrecognized category. JAXB unmarshals an unknown list item
to a null entry rather than failing, so a misspelled category would
otherwise stop excluding the test it was written to exclude, and look
correct doing it. Schema validation would also catch this, but the
suite documents cannot be validated as they stand: testgroups.xml has
a test-group with no name, and name is use="required".
No existing suite declares a category, so nothing changes for callers
other than the getCategory signature.
Declaring hyracks-util brings in @AiProvenance, which is the tree's
convention for AI-authored Java. It is @Retention(SOURCE) and so leaves
no trace for dependency:analyze, hence the usedDependency entry.
Ext-ref: MB-68099
Co-Authored-By: Claude Opus 5 <[email protected]>
Change-Id: I2388a943a987b5fbffecfe7984f5462aaf229489
---
M asterixdb/asterix-test-framework/pom.xml
M
asterixdb/asterix-test-framework/src/main/java/org/apache/asterix/testframework/context/TestCaseContext.java
M asterixdb/asterix-test-framework/src/main/resources/Catalog.xsd
3 files changed, 73 insertions(+), 5 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/64/21664/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21664?usp=email
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: trinity
Gerrit-Change-Id: I2388a943a987b5fbffecfe7984f5462aaf229489
Gerrit-Change-Number: 21664
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Blow <[email protected]>
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Attention: Hussain Towaileb <[email protected]>
