>From Ian Maxon <[email protected]>:

Attention is currently required from: Suryaa Charan Shivakumar.

Ian Maxon has posted comments on this change by Suryaa Charan Shivakumar. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21666?usp=email )

Change subject: [NO ISSUE][DOC] Add cloud mode primer
......................................................................


Patch Set 1:

(7 comments)

Patchset:

PS1:
initial things, the bug it mentions is stopping me from running through it all. 
i'll fix that and continue


File asterixdb/asterix-doc/src/site/markdown/sqlpp/cloud-primer.md:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21666/comment/46c788f7_a48f8633?usp=email
 :
PS1, Line 72: # or, identically, with Docker:
            : docker build -t apache/asterixdb:latest -f 
src/main/resources/Containerfile
this kind of contradicts what's said in lines 55-56. also it doesn't work: if 
-Ppodman.img is goofed then it never copies the asterix-server assembly into 
the target. that is gated behind the profile.


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21666/comment/bfe1cc3c_66770158?usp=email
 :
PS1, Line 77: but it does
            : not work against the pinned `podman-maven-plugin` version and 
fails while parsing its own configuration
we should fix that, but also not mention a bug in a tutorial


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21666/comment/d5e380a2_119546d6?usp=email
 :
PS1, Line 85: | [compose.yml](../cloud-mode/compose.yml) | AsterixDB, the 
durable S3Mock store, the Iceberg S3Mock store, and Nessie |
this table is cool, as well as the files being downloadable like this


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21666/comment/2494dfd5_76ce8c55?usp=email
 :
PS1, Line 87: run-primer.py](../cloud-mode/run-primer.py) | Clean startup, 
readiness, Iceberg seed, every SQL step, restart, assertions, cleanup |
            : | [primer-output.txt
idk about this. the idea of the tutorial is to have the user execute these 
things rather than just run a script without really comprehending what it does


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21666/comment/59d66f34_a5e46351?usp=email
 :
PS1, Line 155: The Java 21 module openings the runtime needs — the management, 
language, NIO, collections, and I/O packages, and in
             : particular `sun.nio.ch` — are baked into the generated launcher 
script rather than passed here. Do not remove them
             : merely because the HTTP server has started: a missing opening 
can fail later during cloud-file initialization and leave
             : the cluster `UNUSABLE`.
i mean like this said its baked into appassembler now so you don't really need 
to mention it, i don't think


File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergConstants.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21666/comment/15d38e5b_57fd11c6?usp=email
 :
PS1, Line 86:     // Besides the credentials themselves, this carries the 
properties that shape how the endpoint is
            :     // addressed: serviceEndpoint alone is not enough, since 
dropping pathStyleAddressing would leave the
            :     // catalog's FileIO client addressing a custom endpoint 
virtual-hosted style while the collection reads
            :     // it path style.
            :     @AiProvenance(agent = AiProvenance.Agent.CLAUDE_SONNET_5, 
tool = AiProvenance.Tool.CLAUDE_CODE_CLI, contributionKind = 
AiProvenance.ContributionKind.ASSISTED, notes = "Carry pathStyleAddressing into 
Iceberg catalog FileIO config; it was previously dropped by "
            :             + "IcebergUtils.filterCatalogProperties, forcing 
virtual-hosted addressing against "
            :             + "path-style-only S3-compatible stores")
            :     public static final List<String> authParams = 
java.util.stream.Stream
            :             .of(AwsConstants.authParams, GCSConstants.authParams, 
AzureConstants.authParams,
            :                     
List.of(S3Constants.PATH_STYLE_ADDRESSING_FIELD_NAME))
            :             .flatMap(java.util.Collection::stream).toList();
            : }
i don't get this. why is it needed to add this here for the tutorial? like in 
DDL terms, what does this allow you to do that you couldn't previously- i 
cannot tell easily from the claudese



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21666?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Iee9a055d4a01a2c239587555b7c4a7c0d35fe05a
Gerrit-Change-Number: 21666
Gerrit-PatchSet: 1
Gerrit-Owner: Suryaa Charan Shivakumar <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-CC: Ian Maxon <[email protected]>
Gerrit-Attention: Suryaa Charan Shivakumar <[email protected]>
Gerrit-Comment-Date: Fri, 04 Sep 2026 00:59:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to