Michael Blow has posted comments on this change. Change subject: Add documentation for query parameters. ......................................................................
Patch Set 6: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1586/6/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameter.md File asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameter.md: PS6, Line 43: suffix I think we should specify "binary unit suffix" or "binary unit symbols" to explicitly indicate that these are base-1024 and not base-1000. PS6, Line 44: "bytes" is the default suffix B is the default suffix. Given that B is the default suffix, maybe we could replace "64-bit integer as bytes, or a 64-bit integer value with KB/MB/GB suffix" with just "64-bit integer value with B/KB/MB/GB suffix" -- To view, visit https://asterix-gerrit.ics.uci.edu/1586 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80dcd668bea3b2b3fff0c0778548ffad63505d99 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
