>From Michael Blow <[email protected]>: Michael Blow has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21972?usp=email )
Change subject: [NO ISSUE][MISC] Keep maven-core out of the build plugins' realms ...................................................................... [NO ISSUE][MISC] Keep maven-core out of the build plugins' realms - user model changes: no - storage format changes: no - interface changes: no Details: Since the advance to 3.10.0, maven-core and maven-compat bring maven-resolver-provider 3.10.0 and with it maven-resolver-transport-file and -transport-apache 2.0.24. license-automation-plugin and asterix-grammar-extension-maven-plugin declared both at compile scope, so those jars entered the plugin realm. Their Sisu components are discovered into the shared container, and the next artifact download anywhere in the reactor picks up FileTransporterFactory 2.0.24. On a Maven 3.8.x runtime that class binds to the core's resolver 1.6.3 API and fails with NoClassDefFoundError: org/eclipse/aether/repository/RepositoryUriUtils. The Maven runtime supplies both artifacts to every plugin, so declare them provided. maven-remote-resources-plugin 1.7.0 also depends on maven-core at compile scope, managed here to 3.10.0, which brings the same jars back into license-automation-plugin's realm; exclude it there. Ext-ref: MB-73268 Generated-by: Claude Opus 5.5 <[email protected]> Change-Id: I336c115eef1eea6fe899b863e23bc368f2672647 Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21972 Reviewed-by: Michael Blow <[email protected]> Tested-by: Michael Blow <[email protected]> --- M asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/pom.xml M hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/pom.xml 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Michael Blow: Looks good to me, approved; Verified diff --git a/asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/pom.xml b/asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/pom.xml index e4cf873..ddac512 100644 --- a/asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/pom.xml +++ b/asterixdb/asterix-maven-plugins/asterix-grammar-extension-maven-plugin/pom.xml @@ -36,10 +36,12 @@ <dependency> <groupId>org.apache.maven</groupId> <artifactId>maven-core</artifactId> + <scope>provided</scope> </dependency> <dependency> <groupId>org.apache.maven</groupId> <artifactId>maven-compat</artifactId> + <scope>provided</scope> </dependency> <!-- dependencies to annotations --> <dependency> diff --git a/hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/pom.xml b/hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/pom.xml index 4fa9be8..04b1f31 100644 --- a/hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/pom.xml +++ b/hyracks-fullstack/hyracks/hyracks-maven-plugins/license-automation-plugin/pom.xml @@ -41,10 +41,17 @@ <dependency> <groupId>org.apache.maven</groupId> <artifactId>maven-core</artifactId> + <scope>provided</scope> </dependency> <dependency> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-remote-resources-plugin</artifactId> + <exclusions> + <exclusion> + <groupId>org.apache.maven</groupId> + <artifactId>maven-core</artifactId> + </exclusion> + </exclusions> </dependency> <dependency> <groupId>com.fasterxml.jackson.core</groupId> @@ -87,6 +94,7 @@ <dependency> <groupId>org.apache.maven</groupId> <artifactId>maven-compat</artifactId> + <scope>provided</scope> </dependency> <dependency> <groupId>org.apache.hyracks</groupId> -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21972?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: asterixdb Gerrit-Branch: trinity Gerrit-Change-Id: I336c115eef1eea6fe899b863e23bc368f2672647 Gerrit-Change-Number: 21972 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]>
