Xikui Wang has posted comments on this change. Change subject: ASTERIXDB-1310 Autogenerated uuid ......................................................................
Patch Set 4: @Steven, the uuid issue is because the inconsistency of datatype between feed and dataset. If you use the datatype with id:uuid autogenerated. That will cause the ADMParser to reject the incoming record because it thinks the non-optional attribute is missing. If we turn that type checking off in ADMParser, that will cause records data messed up when type is not conform to dataset. So I found out actually those changes are not necessary. So creating separate datatypes for feed and dataset works perfectly in this case. ps. I removed that interface change as it's not that important at all and increase the review work. Now this patch should be pretty straight forward to review. Thanks! -- To view, visit https://asterix-gerrit.ics.uci.edu/1601 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief4fba8a7227a40c5d22293758cbdf4575b14401 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: No
