abdullah alamoudi has posted comments on this change. Change subject: Feed Policy Refactoring ......................................................................
Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1591/4/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java: PS4, Line 108: consumer.poison(); Can we remove this call to poison the consumer and instead add a poison pill to the inbox? The consumer thread should know it is time to close once it sees the poison pill. -- To view, visit https://asterix-gerrit.ics.uci.edu/1591 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc10139925cfedee66d1263990ba80b94675f182 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
