Yingyi Bu has posted comments on this change. Change subject: Ensure Metadata locks are acquired for SqlPP queries ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1642/1/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/clause/FromTerm.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/clause/FromTerm.java: PS1, Line 52: if This doesn't look right. SQL++ is a fully compossible language and the field access could really be a a field access. For example: WITH foo as {"a": [1, 2, 3]} SELECT * FROM foo.a; The place does the path resolution is at: -- VariableCheckAndRewriteVisitor -- ResolveVariableRule PS1, Line 59: datasets This doesn't look right. SQL++ is a fully compossible language and the field access could really be a a field access. For example: WITH foo as [1, 2, 3] SELECT * FROM foo; The place does the path resolution is at: -- VariableCheckAndRewriteVisitor -- ResolveVariableRule -- To view, visit https://asterix-gerrit.ics.uci.edu/1642 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f468599897a37cbcb12d8577d072f340f0d949c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
