Yingyi Bu has posted comments on this change. Change subject: Ensure Metadata locks are acquired for SqlPP queries ......................................................................
Patch Set 7: OK, maybe to deal with queryEnd, we need to have two sets to track acquired dv/ds locks in MetadataProvider. But I'm not sure if we need setters for those two sets -- I think we can have method called addLockedDatasets(...) and addLockedDataverses(..) instead of using setters -- if the lock has to be acquired elsewhere. An alternative might to be use mdTxnCtx when acquire locks in MetadataLockManager so that we can release all locks corresponding to a mdTxnCtx at the end of a metadata txn. By that way, we can save some "hold-lock-tracking" code. -- To view, visit https://asterix-gerrit.ics.uci.edu/1642 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f468599897a37cbcb12d8577d072f340f0d949c Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
