Till Westmann has posted comments on this change. Change subject: Adding docker support for writing replication ITs ......................................................................
Patch Set 3: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1644/3/asterixdb/asterix-installer/pom.xml File asterixdb/asterix-installer/pom.xml: PS3, Line 309: tabs? https://asterix-gerrit.ics.uci.edu/#/c/1644/3/asterixdb/asterix-installer/src/test/resources/docker/Dockerfile File asterixdb/asterix-installer/src/test/resources/docker/Dockerfile: PS3, Line 44: COPY remove commented code? PS3, Line 53: WORKDIR remove commented code? https://asterix-gerrit.ics.uci.edu/#/c/1644/3/asterixdb/asterix-installer/src/test/resources/docker/cluster-config.xml File asterixdb/asterix-installer/src/test/resources/docker/cluster-config.xml: PS3, Line 21: vagrant This is not related to the Vagrant software, is it? PS3, Line 76: q What is this 'q' good for? -- To view, visit https://asterix-gerrit.ics.uci.edu/1644 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7948a25f39e1c155ce96502572c1eef122f04bf Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Akshay Manchale <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
