Michael Blow has posted comments on this change.

Change subject: Add Hyracks source assembly back in
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1645/1/hyracks-fullstack/pom.xml
File hyracks-fullstack/pom.xml:

PS1, Line 458:           <plugin>
             :             <groupId>org.apache.maven.plugins</groupId>
             :             <artifactId>maven-assembly-plugin</artifactId>
             :             <!-- We override the configuration plugin to 
override the descriptor to use for building
             :             the source release zip. Specifically, we would like 
to control the inclusions/exclusions.
             :             For example, we exclude the KEYS file from the zip 
-->
             :             <executions>
             :               <execution>
             :                 <!-- Use this id to match the id mentioned in 
the assembly plugin configuration in
             :                 the apache parent POM under the apache-release 
profile -->
             :                 <id>source-release-assembly</id>
             :                 <phase>package</phase>
             :                 <goals>
             :                   <goal>single</goal>
             :                 </goals>
             :                 <!-- combine.self should be override to replace 
the configuration in the parent POM -->
             :                 <configuration combine.self="override">
             :                   <descriptors>
             :                     
<descriptor>src/main/assembly/source.xml</descriptor>
             :                   </descriptors>
             :                 </configuration>
             :               </execution>
             :             </executions>
             :           </plugin>
should this be in release profile, or just in main build like we do for *DB?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1645
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e60a12e03c99486b3136b16645d8dfc772e0b76
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to