Till Westmann has posted comments on this change. Change subject: Ensure Metadata locks are acquired for SQL++ queries ......................................................................
Patch Set 13: (3 comments) Looks generally good to me. But I haven't been able to convince myself that we cannot run into deadlocks. Could you remind me, why we don't? https://asterix-gerrit.ics.uci.edu/#/c/1642/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java: PS13, Line 268: for revert the file? https://asterix-gerrit.ics.uci.edu/#/c/1642/13/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/lock/MetadataLockManager.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/lock/MetadataLockManager.java: PS13, Line 30: Mode Move the Mode to IMetadataLock? https://asterix-gerrit.ics.uci.edu/#/c/1642/13/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java: PS13, Line 60: String dataverseName, String datasetName leftover dataverseName/datasetName -- To view, visit https://asterix-gerrit.ics.uci.edu/1642 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f468599897a37cbcb12d8577d072f340f0d949c Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
