Steven Jacobs has posted comments on this change. Change subject: Fix Pre-Distributed Jobs ......................................................................
Patch Set 2: (2 comments) replied https://asterix-gerrit.ics.uci.edu/#/c/1656/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/dataset/DatasetDirectoryService.java: Line 186: public synchronized long getStateTimestamp(JobId jobId) { > Any particular reason to change this interface from returning IDatasetState Although this function returned the whole state, it's only ever used to get the timestamp for the state, so I changed it to return that instead. I think if someone actually wants the state in the future they can modify or add, but it seemed pointless to return more data than used by the caller https://asterix-gerrit.ics.uci.edu/#/c/1656/2/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/PredistributedJobsTest.java File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/PredistributedJobsTest.java: Line 147: Thread.sleep(300000); > Why this sleep is necessary? Could you add a small note to this test? kind This is just to verify that the result sweeper doesn't kill the job (it executes every 2 minutes). Added a comment and changed it to three minutes to save time. -- To view, visit https://asterix-gerrit.ics.uci.edu/1656 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id50c52fbc7c891761dcabd654fb9b853b5f7a91d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
