Ian Maxon has submitted this change and it was merged. Change subject: Handle Empty Version In Case Of Build Outside Git ......................................................................
Handle Empty Version In Case Of Build Outside Git When the product is built outside of Git (e.g. from source assembly), the version servlet API will return an empty result. Update expected result to accept this to enable testing from source assembly Change-Id: Ic284dd43f9b7b2da700b21b6a2d23769cd562aea Reviewed-on: https://asterix-gerrit.ics.uci.edu/1659 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Ian Maxon <[email protected]> --- M asterixdb/asterix-app/src/test/resources/runtimets/results/api/version_1/version_1.1.regex 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ian Maxon: Looks good to me, approved Jenkins: Verified; No violations found; Verified Objections: Jenkins: Violations found diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/version_1/version_1.1.regex b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/version_1/version_1.1.regex index f6dbe93..f9dc064 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/results/api/version_1/version_1.1.regex +++ b/asterixdb/asterix-app/src/test/resources/runtimets/results/api/version_1/version_1.1.regex @@ -1 +1 @@ -/"git.build.version"/ +/(^\{\}$|"git.build.version")/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1659 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic284dd43f9b7b2da700b21b6a2d23769cd562aea Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]>
