Steven Jacobs has posted comments on this change. Change subject: Fix Pre-Distributed Jobs ......................................................................
Patch Set 3: (3 comments) Addressed Comments. Will upload the next patchset https://asterix-gerrit.ics.uci.edu/#/c/1656/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: PS5, Line 1739: > try{ Done https://asterix-gerrit.ics.uci.edu/#/c/1656/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetManager.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/dataset/IDatasetManager.java: Line 29: public long getStateTimestamp(JobId jobId); > I tend to agree with Xikui here. If there's a vote, I'm +1 on keeping the I Done https://asterix-gerrit.ics.uci.edu/#/c/1656/5/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/dataset/ResultStateSweeper.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/dataset/ResultStateSweeper.java: PS5, Line 74: toBeCollected > What is the lifecycle of the results of predistributed jobs? When are they There is a destroyJob method that removes the Job information from the CC and NC services, at which point this will return the time that the result store was originally created (when the job was distributed), allowing the sweeper to reinitialize the job and free-up the storage here. -- To view, visit https://asterix-gerrit.ics.uci.edu/1656 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id50c52fbc7c891761dcabd654fb9b853b5f7a91d Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
