Yingyi Bu has posted comments on this change. Change subject: Fix ASTERIXDB-1875 UDF in SQL++ ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1666/3/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java: PS3, Line 136: variableCheckAndRewrite > Inlines WITH expressions after variableCheckAndRewrite(...) so that the var E.g., WITH bar (SELECT * FROM foo) SELECT * FROM temp AS foo, bar; If we do variableCheckAndRewrite after inlineWithExpressions, then, it will become SELECT * FROM temp, (SELECT * FROM temp) bar; which is not correct regarding to the WITH semantics. -- To view, visit https://asterix-gerrit.ics.uci.edu/1666 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf72c690b452dd141efe56f5d7098a6f00cab0f Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
