abdullah alamoudi has posted comments on this change. Change subject: Cleanup storage exceptions ......................................................................
Patch Set 8: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1619/8/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java: PS8, Line 678: Exception > No remote exception thrown from here? Done PS8, Line 867: Exception > no remote exception thrown? Done https://asterix-gerrit.ics.uci.edu/#/c/1619/8/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/NodeGroupTupleTranslator.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/NodeGroupTupleTranslator.java: Line 81: List<String> nodeNames = new ArrayList<>(); > Fix this? Done Line 81: List<String> nodeNames = new ArrayList<>(); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1619/8/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexExamplesTest.java File hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexExamplesTest.java: Line 595: e.printStackTrace(); > e.printStackTrace() is not needed since you propagate e? Done PS8, Line 739: > The code in the three if-else-if branches are exactly the same, can you uni Done. Sorry. I must've missed it by mistake :) -- To view, visit https://asterix-gerrit.ics.uci.edu/1619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I020d2b4b1f4ae48fc2df0b720e70a1ce95867d34 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
