Michael Blow has posted comments on this change. Change subject: ASTERIXDB-1884: pretty printing of explain results ......................................................................
Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1687/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java: PS4, Line 167: if JSON parsing fails, just use the original string is this an expected condition? should we be logging even if we proceed? -- To view, visit https://asterix-gerrit.ics.uci.edu/1687 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20a697610e2ac78b25b5a61d6d7348534330af37 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
