Michael Carey has posted comments on this change. Change subject: Document the Query Service API ......................................................................
Patch Set 1: (4 comments) I've added a few comments... https://asterix-gerrit.ics.uci.edu/#/c/1698/1/asterixdb/asterix-doc/src/site/markdown/api.md File asterixdb/asterix-doc/src/site/markdown/api.md: Line 43: __Command (immedidate result delivery)__ immedidate -> immediate Line 45: $ curl -v --data-urlencode "statement=select 1;" \ I would suggest using a slightly more interesting query here - partly to make the results a little more illustrative on the JSON side, partly to clarify some encoding questions that might arise, and partly to make the timings a bit more illustrative on the performance side in the async case (maybe). E.g.: SELECT ds.BucketName, ds.DatasetName, ds.`Filter` FROM Metadata.`Dataset` ds WHERE ds.DataverseName LIKE "D%"; Line 157: $ curl -v http://localhost:19002/query/service/status/9-0 What is the /9-0 suffix here? More generally, maybe there needs to be a sentence about how one correlates the subsequent requests to the query request? I assume this is (somehow) the answer to that. :-) Line 182: $ curl -v http://localhost:19002/query/service/result/7-0 Same question/comment here. -- To view, visit https://asterix-gerrit.ics.uci.edu/1698 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcefb1671ea305a5958c9a74a588b4aaa17f399f Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-HasComments: Yes
