Till Westmann has posted comments on this change. Change subject: Refactor TestExecutor ......................................................................
Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1705/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java: PS2, Line 975: getPost Maybe call this httpRequest or something list this? getPost confused me when I read it first. Also, we should align the order of the parameters with query() and the other methods. PS2, Line 1003: query I think that we should align the order of the parameters with executeSqlppUpdate and keep these methods adjacent to each other in the source file. PS2, Line 1097: executeSqlppDdl executeSqlppUpdate and executeSqlppDdl are essentially the same method. I think that we should only have one. Also, it should probably return the result of ResultExtractor.extract and lets the caller decide if the result should be ignored. -- To view, visit https://asterix-gerrit.ics.uci.edu/1705 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
