Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1892: Sets a proper hash table cardinality during hash-group by ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1702/3/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java: PS3, Line 250: private > Are there many cases that you iterative over all bytes in the header and yo Maybe if compacting the content frames give me one or more frame, then this operation might not be necessary. But, for the future operations, this clearly affect spilling since the header frames will never shrink. The header size is smaller compared to that of the content frames. And once the content frames are compacted, I think the corresponding the header frame needs to be compacted (released), too. One idea might be: we can limit the number of header frames that needs to be checked: maybe MAX 100. During the content frame compaction, we mark the corresponding header frames and check those frames only. -- To view, visit https://asterix-gerrit.ics.uci.edu/1702 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I651139b2b559ad4d2f6137a5c844814606516a90 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
