Ian Maxon has posted comments on this change. Change subject: Make Index Op Contexts fields private ......................................................................
Patch Set 1: (3 comments) Couple sonarqube comments that seem prudent to address, other than that +2 https://asterix-gerrit.ics.uci.edu/#/c/1712/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/PartitionedInMemoryInvertedIndex.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/inmemory/PartitionedInMemoryInvertedIndex.java: Line 135: inMemListCursor.prepare(ctx.getBtreeAccessor(), ctx.getBtreePred(), ctx.getTokenFieldsCmp(), ctx.getBtreeCmp()); > MAJOR SonarQube violation: +1 https://asterix-gerrit.ics.uci.edu/#/c/1712/1/hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTreeOpContext.java File hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTreeOpContext.java: Line 160: public ArrayList<ICachedPage> getLSNUpdates() { > MAJOR SonarQube violation: +1 Line 172: public ArrayList<ICachedPage> getNSNUpdates() { > MAJOR SonarQube violation: +1 -- To view, visit https://asterix-gerrit.ics.uci.edu/1712 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic027e998559e312ee0e0cb7f41d5d82f53eee985 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
