Jianfeng Jia has posted comments on this change. Change subject: Carry filter in 2ndary-to-primary index search ......................................................................
Patch Set 6: (6 comments) @Yingyi @Ian, this is patch expose the filter value and pass it along with index record in the dataflow pipeline. The next patch will address the logical plan rule changes to create corresponding hyracks jobs. https://asterix-gerrit.ics.uci.edu/#/c/1720/1/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexSearchOperatorNodePushable.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexSearchOperatorNodePushable.java: Line 276: for (int i = 0; i < numFields; i++) { > CRITICAL SonarQube violation: Done Line 277: try { > CRITICAL SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1720/4/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexSearchOperatorNodePushable.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexSearchOperatorNodePushable.java: Line 278: nonMatchWriter.writeMissing(out); > CRITICAL SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1720/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java: Line 244: if (foundTuple) { > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1720/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddySortedCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddySortedCursor.java: Line 86: if (foundIn < 0) { > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1720/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java: Line 208: if (accessorIndex < 0) { > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1720 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I287f1dbd230aa649f1350114abf0a1d47e2bb53c Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
