Yingyi Bu has posted comments on this change. Change subject: Rename several type tags to improve error messages: ......................................................................
Patch Set 4: (14 comments) https://asterix-gerrit.ics.uci.edu/#/c/1724/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java: Line 768: case ARRAY: > MAJOR SonarQube violation: Done Line 1160: && (indexType == IndexType.SINGLE_PARTITION_WORD_INVIX > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1724/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java: Line 1158: boolean isVar = nonConstArg.getExpressionTag() == LogicalExpressionTag.VARIABLE; > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1724/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataParser.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataParser.java: Line 63: case OBJECT: { > MAJOR SonarQube violation: Done Line 71: case ARRAY: { > MAJOR SonarQube violation: Done Line 86: case MULTISET: { > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1724/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryHashFunctionFamilyProvider.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/BinaryHashFunctionFamilyProvider.java: Line 30: * We use a binary hash function that promotes numeric types (tinyint,smallint,integer,bigint,float) to double > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1724/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericDoubleOutputFunctionTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericDoubleOutputFunctionTypeComputer.java: Line 50: throw new TypeMismatchException(funcName, argIndex, tag, ATypeTag.TINYINT, ATypeTag.SMALLINT, > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1724/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericInt8OutputFunctionTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericInt8OutputFunctionTypeComputer.java: Line 49: throw new TypeMismatchException(funcName, argIndex, tag, ATypeTag.TINYINT, ATypeTag.SMALLINT, > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1724/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericUnaryFunctionTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericUnaryFunctionTypeComputer.java: Line 52: throw new TypeMismatchException(funcName, argIndex, tag, ATypeTag.TINYINT, ATypeTag.SMALLINT, > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1724/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java: Line 226: ARecordType subRecord = (ARecordType) fieldTypes[i]; > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1724/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/UnaryMinusTypeComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/UnaryMinusTypeComputer.java: Line 47: throw new TypeMismatchException(funcName, argIndex, tag, ATypeTag.TINYINT, ATypeTag.SMALLINT, > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1724/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/ATypeHierarchy.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/ATypeHierarchy.java: Line 699: // Get a LONG (bigint) value from numeric types array. We assume the specific location of a byte array > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1724/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/AbstractIntegerTypeConvertComputer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/hierachy/AbstractIntegerTypeConvertComputer.java: Line 66: throw new IOException("Can't convert integer types. The source type should be one of " > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1724 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a2eb6534f80af102832f079dfcb92fab5fc34fa Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
