abdullah alamoudi has posted comments on this change.

Change subject: Refactor TestExecutor
......................................................................


Patch Set 6: Code-Review+2

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1705/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java:

PS2, Line 975:        
> Maybe call this httpRequest or something list this? getPost confused me whe
Done


PS2, Line 1003: p".eq
> I think that we should align the order of the parameters with executeSqlppU
Done


PS2, Line 1097: tch (Exception 
> executeSqlppUpdate and executeSqlppDdl are essentially the same method. I t
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1705
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c586ad12f059eaf29c4031ccdcff10d0fb46aa0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to