Michael Blow has posted comments on this change. Change subject: Enable HTTP API processing on NCs ......................................................................
Patch Set 8: (5 comments) Good stuff! https://asterix-gerrit.ics.uci.edu/#/c/1709/8/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java: PS8, Line 468: if (err instanceof Exception) { : throw (Exception) err; : } else if (err instanceof TokenMgrError) { : throw (TokenMgrError) err; : } else if (err instanceof org.apache.asterix.aqlplus.parser.TokenMgrError) { : throw (org.apache.asterix.aqlplus.parser.TokenMgrError) err; : } else { : throw new Exception(err.toString()); : } why can't we just throw err here, and update catch below (line 493) to catch Throwable? https://asterix-gerrit.ics.uci.edu/#/c/1709/8/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java: PS8, Line 140: e.getMessage() toString here? getMessage is often null or meaningless without context of exception class for arbitrary Exception types PS8, Line 147: e.getMessage() same as toString comment above https://asterix-gerrit.ics.uci.edu/#/c/1709/8/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java: Line 823: Thread.sleep(8000); > MAJOR SonarQube violation: Why do we need to sleep 8s after every managix command now after this change? https://asterix-gerrit.ics.uci.edu/#/c/1709/8/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixLifecycleIT.java File asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixLifecycleIT.java: Line 91: Thread.sleep(4000); > MAJOR SonarQube violation: What problem are we solving with this? Is stop returning before the cluster is actually stopped? -- To view, visit https://asterix-gerrit.ics.uci.edu/1709 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19414a23e163fc4deef9805c8f9089609f1ebe07 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
