Luo Chen has posted comments on this change. Change subject: Implemented LSM disk components alignment ......................................................................
Patch Set 13: (2 comments) > (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1725/7/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java: PS7, Line 337: > I'm not sure that's quite right either. Why does the index need to know abo When talking about components correlation, what it really means is that all disk components of all indexes of a dataset partition should be correlated. Indexes of different partitions of a dataset (even if they are in the same NC) could have different number of components. Suppose a NC has two partitions P1 and P2 for a dataset. They share the same memory budget for memory components and the same PrimaryOperationTracker. Whenever P1 or P2 is full would make all indexes of P1 and P2 to be flushed. However, when memory components of P1 are full, it is possible that memory components of P2 are not flashable, e.g., they are empty or flushing, and thus there's nothing to be flushed for P2. Thus, we need to group the flush operation of all indexes of one partition, instead of all indexes of all partitions blindly. https://asterix-gerrit.ics.uci.edu/#/c/1725/7/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS7, Line 458: ex > Ok, well, maybe a comment or something to make that more explicit would be Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1725 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64bf34e255def72adc73b9f87cfa628a172ea694 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
