Till Westmann has posted comments on this change. Change subject: Enable job compilation for variables that will be created at runtime ......................................................................
Patch Set 7: I think that the change generally looks good. But I do have one question/request: Could we use "job parameter" (or "job param") instead of "runtime context variable"? This would align nicely with the "JobFlags" and it would make sense as a parameter to e.g. "startJob". Method parameters like "contextRuntTimeVarMap" could be called "jobParameters" (or "jobParams"). Unless it’s semantically incorrect, I think that we should do such a change at least for the Hyracks part of the change. For the AsterixDB function, we can decide if we want to keep that the way it is or rename that as well. What do you think? (I would also do the change.) -- To view, visit https://asterix-gerrit.ics.uci.edu/1722 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie66ed97d9c25cb64afc8ac38d6675211cf76d97b Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: No
