Steven Jacobs has posted comments on this change. Change subject: Enable job compilation for variables that will be assigned at runtime ......................................................................
Patch Set 8: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1722/8//COMMIT_MSG Commit Message: PS8, Line 9: Runtime Context Variables > job parameters Done https://asterix-gerrit.ics.uci.edu/#/c/1722/8/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobParameterByteStore.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobParameterByteStore.java: PS8, Line 45: getParameterValue > How about thread safety? For example, if you have concurrent requests for Right now two concurrent requests for the same predistributed job will fail (not sure of all of the issues). I'm posting a code review this week that explicitly prevents users from doing this, so I think this is an orthogonal (and more involved) issue. I'll create a Jira issue for allowing concurrent execution of one pre-distributed job. -- To view, visit https://asterix-gerrit.ics.uci.edu/1722 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie66ed97d9c25cb64afc8ac38d6675211cf76d97b Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
