Michael Blow has posted comments on this change. Change subject: Do not include Exception class in error message ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1757/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ResultUtil.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ResultUtil.java: PS2, Line 129: "(" + msg + ")" 1. What is the advantage of doing ClassName(message) -vs- ClassName: message like the JDK does? 2. Either way I'd guard this in a msg == null ? "" : ... since NullPointerException(null) isn't very friendly. -- To view, visit https://asterix-gerrit.ics.uci.edu/1757 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33c76222dabfe6ede67dbcd7f0992cbb047265ef Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
