Taewoo Kim has posted comments on this change. Change subject: Change logical plan to apply filter from 2ndary index ......................................................................
Patch Set 7: (7 comments) General comments for each test: can you put a description on each test? What the given test is intended for? And it might be a good idea to print filter information in the physical operator, too since the optimizer Test result doesn't tell us much. https://asterix-gerrit.ics.uci.edu/#/c/1727/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java: Line 355: // TODO look at here about the variables Can you be more specific about this comment? https://asterix-gerrit.ics.uci.edu/#/c/1727/7/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java: PS7, Line 262: Can these two switch() be combined? Line 291: private void propagateFilterInSecondaryUnnest(UnnestMapOperator secondaryUnnest, IAType filterType, propagateFilterInSecondaryUnnsetMap? Line 305: private void setFilterValueFromSecondaryUnnest(UnnestMapOperator primaryOp, setFilterValueFromSecondaryUnnestMap? https://asterix-gerrit.ics.uci.edu/#/c/1727/7/asterixdb/asterix-app/data/twitter/real.2.adm File asterixdb/asterix-app/data/twitter/real.2.adm: Line 1: { "create_at": datetime("2016-01-02T10:00:00.000Z"), "id": 683347019176501248, "text": "@e_tomkiewicz o I know", "in_reply_to_status": 683306019192176642, "in_reply_to_user": 379427210, "favorite_count": 0, "retweet_count": 0, "lang": "en", "is_retweet": false, "user_mentions": {{ 379427210 }}, "user": { "id": 51597840, "name": "Sydney Isroff", "screen_name": "SydneyIsroff", "lang": "en", "location": "null", "create_at": date("2009-06-27"), "description": "Kids are allowed but not welcomed", "followers_count": 408, "friends_count": 78, "statues_count": 13278 }, "place": { "country": "United States", "country_code": "United States", "full_name": "Milwaukee, WI", "id": "2a93711775303f90", "name": "Milwaukee", "place_type": "city", "bounding_box": rectangle("-88.070827,42.920822 -87.863758,43.192623") }, "geo_tag": { "stateID": 55, "stateName": "Wisconsin", "countyID": 55079, "countyName": "Milwaukee", "cityID": 5553000, "cityName": "Milwaukee" } } Do we need 10,000 tuples in a test case? https://asterix-gerrit.ics.uci.edu/#/c/1727/7/asterixdb/asterix-app/data/twitter/real.adm File asterixdb/asterix-app/data/twitter/real.adm: Line 1: { "create_at": datetime("2015-11-23T16:14:03.000Z"), "id": 668945640186101761, "text": "Just posted a photo @ Campus Martius Park https://t.co/5Ax4E2CdWZ";, "in_reply_to_status": -1, "in_reply_to_user": -1, "favorite_count": 0, "coordinate": point("-83.04647491,42.33170228"), "retweet_count": 0, "lang": "en", "is_retweet": false, "user": { "id": 48121888, "name": "Kevin McKague", "screen_name": "KevinOfMI", "lang": "en", "location": "Davison, Michigan", "create_at": date("2009-06-17"), "description": "I need to ride my bike until my brain shuts up and my muscles are screaming. \nRight after these donuts. Dad of 3.\n Visit my blog 18 Wheels and a 12-Speed Bike.", "followers_count": 1178, "friends_count": 1780, "statues_count": 22263 }, "place": { "country": "United States", "country_code": "United States", "full_name": "Detroit, MI", "id": "b463d3bd6064861b", "name": "Detroit", "place_type": "city", "bounding_box": rectangle("-83.288056,42.255085 -82.91052,42.450488") }, "geo_tag": { "stateID": 26, "stateName": "Michigan", "countyID": 26163, "countyName": "Wayne", "cityID": 2622000, "cityName": "Detroit" } } Do we need 20,000 tuples in a test case? https://asterix-gerrit.ics.uci.edu/#/c/1727/7/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/am/rtree/AbstractRTreeOperatorTest.java File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/am/rtree/AbstractRTreeOperatorTest.java: Line 26: import org.apache.hyracks.api.dataflow.value.*; Our principle is not doing *? Isn't it? Maybe Till needs to check this. -- To view, visit https://asterix-gerrit.ics.uci.edu/1727 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e2fe0208662e5dcd49d1a22bfb58f96533e9497 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
