[
https://issues.apache.org/jira/browse/ASTERIXDB-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017714#comment-16017714
]
Taewoo Kim commented on ASTERIXDB-1907:
---------------------------------------
OK. Let me check the codebase to make sure we don't have any case where
ignoreCase = false for all string comparison cases.
> Unify the two methods in IBinaryComparatorFactoryProvider
> ---------------------------------------------------------
>
> Key: ASTERIXDB-1907
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1907
> Project: Apache AsterixDB
> Issue Type: Bug
> Components: Hyracks Core
> Reporter: Abdullah Alamoudi
> Assignee: Abdullah Alamoudi
>
> The interface {{IBinaryComparatorFactoryProvider}} has 2 methods
> {{getBinaryComparatorFactory}}, one with the parameters
> {noformat}
> (Object type, boolean ascending)
> {noformat}
> and one with the parameters
> {noformat}
> (Object type, boolean ascending, boolean ignoreCase)
> {noformat}
> The 2nd signature seems problematic, as it is not clear what {{ignoreCase}}
> should mean for a non-string datatype.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)