abdullah alamoudi has posted comments on this change. Change subject: Fix upsert deadlock and upsert with filtered primary only bug ......................................................................
Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1759/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java: Line 253: if ((isFiltered || hasSecondaries) && prevTuple != null) { > Would you want to update the filter if hasSecondaries but not filtered? if not filtered, what does update the filter mean?? PS2, Line 254: // need to update the filter of the new component with the previous value : lsmAccessor.updateFilter(prevTuple); > Wait, why would you want to update the filter with the previous value? because if the dataset is filtered, you don't want the search to pick up the old component but not the new one where the value has been overwritten. https://asterix-gerrit.ics.uci.edu/#/c/1759/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS2, Line 381: if (!lsmIndex.isMemoryComponentsAllocated()) { > Is there a chance to update the filter before entering the index? As per the current implementation of the primary upsert operation which is the only operator that calls this, there is no way this would be called without entering the memory component first. -- To view, visit https://asterix-gerrit.ics.uci.edu/1759 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic702d6e1984ea33408c360b6f522f493848cbd87 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
