abdullah alamoudi has posted comments on this change. Change subject: Implemented Disk Components Alignment Based on IDs ......................................................................
Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1761/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java: PS6, Line 103: isMergeLagging( > Both solutions (with or without flow control) are solution OK to me. But wi That should be fine because the merge policy should always checks the primary index disk components on that partition. What I am suggesting is only that when a secondary component is written to disk, the policy should still check the primary. think of the following scenario: You create 2 disk components each and you schedule a merge. the merge starts with the primary index and finish while the secondaries are still being merged. then let's say 10 components are added to each index. each time a component is added, it checks and sees that the secondaries are still being merged, so it doesn't schedule any. let's say at that point, data stops coming and all the secondaries are merged. the last secondary to finish the merge should schedule the next set of merges. otherwise, the system will have to wait until a new primary component is flushed. -- To view, visit https://asterix-gerrit.ics.uci.edu/1761 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I768ee9ac0a8d3c99c631086093a6b778b2e7588e Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
