abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1779
Change subject: Rename Component Filter Factory
......................................................................
Rename Component Filter Factory
Change-Id: I1b3d9bef3fb6118c66195630cec23a7e41fc5861
---
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentFactory.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java
R
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/IComponentFilterFactoryAndComparatorFactoriesProvider.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java
R
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ComponentFilterFactoryAndComparatorFactoriesProvider.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexDiskComponentFactory.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/PartitionedLSMInvertedIndex.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/util/InvertedIndexUtils.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTree.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeDiskComponentFactory.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuples.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesDiskComponentFactory.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/utils/LSMRTreeUtils.java
16 files changed, 62 insertions(+), 54 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/79/1779/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java
index 29532d4..21b989a 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java
@@ -44,8 +44,8 @@
import org.apache.hyracks.storage.am.common.api.ITreeIndexFrameFactory;
import org.apache.hyracks.storage.am.common.impls.NoOpOperationCallback;
import org.apache.hyracks.storage.am.lsm.btree.tuples.LSMBTreeTupleReference;
+import
org.apache.hyracks.storage.am.lsm.common.api.IComponentFilterFactoryAndComparatorFactoriesProvider;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponent;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFactory;
import
org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFrameFactory;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponent;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMIOOperation;
@@ -99,7 +99,7 @@
ITreeIndexFrameFactory interiorFrameFactory,
ITreeIndexFrameFactory insertLeafFrameFactory,
ITreeIndexFrameFactory deleteLeafFrameFactory,
ILSMIndexFileManager fileManager,
TreeIndexFactory<BTree> diskBTreeFactory, TreeIndexFactory<BTree>
bulkLoadBTreeFactory,
- BloomFilterFactory bloomFilterFactory, ILSMComponentFilterFactory
filterFactory,
+ BloomFilterFactory bloomFilterFactory,
IComponentFilterFactoryAndComparatorFactoriesProvider filterFactory,
ILSMComponentFilterFrameFactory filterFrameFactory,
LSMComponentFilterManager filterManager,
double bloomFilterFalsePositiveRate, IFileMapProvider
diskFileMapProvider, int fieldCount,
IBinaryComparatorFactory[] cmpFactories, ILSMMergePolicy
mergePolicy, ILSMOperationTracker opTracker,
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentFactory.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentFactory.java
index a8845cc..f0e4421 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentFactory.java
@@ -22,7 +22,7 @@
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.storage.am.bloomfilter.impls.BloomFilterFactory;
import org.apache.hyracks.storage.am.btree.impls.BTree;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFactory;
+import
org.apache.hyracks.storage.am.lsm.common.api.IComponentFilterFactoryAndComparatorFactoriesProvider;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponentFactory;
import
org.apache.hyracks.storage.am.lsm.common.impls.LSMComponentFileReferences;
import org.apache.hyracks.storage.am.lsm.common.impls.TreeIndexFactory;
@@ -30,10 +30,10 @@
public class LSMBTreeDiskComponentFactory implements ILSMDiskComponentFactory {
private final TreeIndexFactory<BTree> btreeFactory;
private final BloomFilterFactory bloomFilterFactory;
- private final ILSMComponentFilterFactory filterFactory;
+ private final IComponentFilterFactoryAndComparatorFactoriesProvider
filterFactory;
public LSMBTreeDiskComponentFactory(TreeIndexFactory<BTree> btreeFactory,
BloomFilterFactory bloomFilterFactory,
- ILSMComponentFilterFactory filterFactory) {
+ IComponentFilterFactoryAndComparatorFactoriesProvider
filterFactory) {
this.btreeFactory = btreeFactory;
this.bloomFilterFactory = bloomFilterFactory;
this.filterFactory = filterFactory;
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java
index baedc78..35c87e5 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java
@@ -49,7 +49,7 @@
import org.apache.hyracks.storage.am.lsm.common.api.IVirtualBufferCache;
import
org.apache.hyracks.storage.am.lsm.common.frames.LSMComponentFilterFrameFactory;
import org.apache.hyracks.storage.am.lsm.common.impls.BTreeFactory;
-import
org.apache.hyracks.storage.am.lsm.common.impls.LSMComponentFilterFactory;
+import
org.apache.hyracks.storage.am.lsm.common.impls.ComponentFilterFactoryAndComparatorFactoriesProvider;
import
org.apache.hyracks.storage.am.lsm.common.impls.LSMComponentFilterManager;
import org.apache.hyracks.storage.am.lsm.common.impls.TreeIndexFactory;
import org.apache.hyracks.storage.common.buffercache.IBufferCache;
@@ -88,12 +88,13 @@
BloomFilterFactory bloomFilterFactory = needKeyDupCheck
? new BloomFilterFactory(diskBufferCache, diskFileMapProvider,
bloomFilterKeyFields) : null;
- LSMComponentFilterFactory filterFactory = null;
+ ComponentFilterFactoryAndComparatorFactoriesProvider filterFactory =
null;
LSMComponentFilterFrameFactory filterFrameFactory = null;
LSMComponentFilterManager filterManager = null;
if (filterCmpFactories != null) {
TypeAwareTupleWriterFactory filterTupleWriterFactory = new
TypeAwareTupleWriterFactory(filterTypeTraits);
- filterFactory = new
LSMComponentFilterFactory(filterTupleWriterFactory, filterCmpFactories);
+ filterFactory = new
ComponentFilterFactoryAndComparatorFactoriesProvider(filterTupleWriterFactory,
+ filterCmpFactories);
filterFrameFactory = new
LSMComponentFilterFrameFactory(filterTupleWriterFactory);
filterManager = new LSMComponentFilterManager(filterFrameFactory);
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMComponentFilterFactory.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/IComponentFilterFactoryAndComparatorFactoriesProvider.java
similarity index 93%
rename from
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMComponentFilterFactory.java
rename to
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/IComponentFilterFactoryAndComparatorFactoriesProvider.java
index 6284d4e..4ac6ff9 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMComponentFilterFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/IComponentFilterFactoryAndComparatorFactoriesProvider.java
@@ -20,7 +20,7 @@
import org.apache.hyracks.api.dataflow.value.IBinaryComparatorFactory;
-public interface ILSMComponentFilterFactory {
+public interface IComponentFilterFactoryAndComparatorFactoriesProvider {
/**
* @return an instance of ILSMComponentFilter
*/
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java
index 7c34326..8bfe248 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java
@@ -40,9 +40,9 @@
import org.apache.hyracks.storage.am.common.impls.AbstractSearchPredicate;
import org.apache.hyracks.storage.am.common.impls.NoOpOperationCallback;
import org.apache.hyracks.storage.am.common.ophelpers.IndexOperation;
+import
org.apache.hyracks.storage.am.lsm.common.api.IComponentFilterFactoryAndComparatorFactoriesProvider;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponent;
import
org.apache.hyracks.storage.am.lsm.common.api.ILSMComponent.ComponentState;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFactory;
import
org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFrameFactory;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponent;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMHarness;
@@ -83,7 +83,7 @@
protected final List<ILSMDiskComponent> diskComponents;
protected final List<ILSMDiskComponent> inactiveDiskComponents;
protected final double bloomFilterFalsePositiveRate;
- protected final ILSMComponentFilterFactory filterFactory;
+ protected final IComponentFilterFactoryAndComparatorFactoriesProvider
filterFactory;
protected final ILSMComponentFilterFrameFactory filterFrameFactory;
protected final LSMComponentFilterManager filterManager;
protected final int[] treeFields;
@@ -98,7 +98,8 @@
double bloomFilterFalsePositiveRate, ILSMMergePolicy mergePolicy,
ILSMOperationTracker opTracker,
ILSMIOOperationScheduler ioScheduler, ILSMIOOperationCallback
ioOpCallback,
ILSMComponentFilterFrameFactory filterFrameFactory,
LSMComponentFilterManager filterManager,
- int[] filterFields, boolean durable, ILSMComponentFilterFactory
filterFactory, int[] treeFields) {
+ int[] filterFields, boolean durable,
IComponentFilterFactoryAndComparatorFactoriesProvider filterFactory,
+ int[] treeFields) {
this.ioManager = ioManager;
this.virtualBufferCaches = virtualBufferCaches;
this.diskBufferCache = diskBufferCache;
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterFactory.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ComponentFilterFactoryAndComparatorFactoriesProvider.java
similarity index 82%
rename from
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterFactory.java
rename to
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ComponentFilterFactoryAndComparatorFactoriesProvider.java
index 390321f..5585648 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ComponentFilterFactoryAndComparatorFactoriesProvider.java
@@ -20,15 +20,16 @@
import org.apache.hyracks.api.dataflow.value.IBinaryComparatorFactory;
import org.apache.hyracks.storage.am.common.api.ITreeIndexTupleWriterFactory;
+import
org.apache.hyracks.storage.am.lsm.common.api.IComponentFilterFactoryAndComparatorFactoriesProvider;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilter;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFactory;
-public class LSMComponentFilterFactory implements ILSMComponentFilterFactory {
+public class ComponentFilterFactoryAndComparatorFactoriesProvider
+ implements IComponentFilterFactoryAndComparatorFactoriesProvider {
private final ITreeIndexTupleWriterFactory tupleWriterFactory;
private final IBinaryComparatorFactory[] filterCmpFactories;
- public LSMComponentFilterFactory(ITreeIndexTupleWriterFactory
tupleWriterFactory,
+ public
ComponentFilterFactoryAndComparatorFactoriesProvider(ITreeIndexTupleWriterFactory
tupleWriterFactory,
IBinaryComparatorFactory[] filterCmpFactories) {
this.tupleWriterFactory = tupleWriterFactory;
this.filterCmpFactories = filterCmpFactories;
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
index 89d8f0b..d16c3d6 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
@@ -44,9 +44,9 @@
import org.apache.hyracks.storage.am.common.api.IIndexOperationContext;
import org.apache.hyracks.storage.am.common.impls.NoOpOperationCallback;
import org.apache.hyracks.storage.am.common.tuples.PermutingTupleReference;
+import
org.apache.hyracks.storage.am.lsm.common.api.IComponentFilterFactoryAndComparatorFactoriesProvider;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponent;
import
org.apache.hyracks.storage.am.lsm.common.api.ILSMComponent.LSMComponentType;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFactory;
import
org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFrameFactory;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponent;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponentFactory;
@@ -107,7 +107,7 @@
public LSMInvertedIndex(IIOManager ioManager, List<IVirtualBufferCache>
virtualBufferCaches,
OnDiskInvertedIndexFactory diskInvIndexFactory, BTreeFactory
deletedKeysBTreeFactory,
- BloomFilterFactory bloomFilterFactory, ILSMComponentFilterFactory
filterFactory,
+ BloomFilterFactory bloomFilterFactory,
IComponentFilterFactoryAndComparatorFactoriesProvider filterFactory,
ILSMComponentFilterFrameFactory filterFrameFactory,
LSMComponentFilterManager filterManager,
double bloomFilterFalsePositiveRate, ILSMIndexFileManager
fileManager, IFileMapProvider diskFileMapProvider,
ITypeTraits[] invListTypeTraits, IBinaryComparatorFactory[]
invListCmpFactories,
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexDiskComponentFactory.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexDiskComponentFactory.java
index 270d3a1..ff64e40 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexDiskComponentFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexDiskComponentFactory.java
@@ -22,7 +22,7 @@
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.storage.am.bloomfilter.impls.BloomFilterFactory;
import org.apache.hyracks.storage.am.btree.impls.BTree;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFactory;
+import
org.apache.hyracks.storage.am.lsm.common.api.IComponentFilterFactoryAndComparatorFactoriesProvider;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponentFactory;
import
org.apache.hyracks.storage.am.lsm.common.impls.LSMComponentFileReferences;
import org.apache.hyracks.storage.am.lsm.common.impls.TreeIndexFactory;
@@ -32,11 +32,11 @@
private final OnDiskInvertedIndexFactory diskInvIndexFactory;
private final TreeIndexFactory<BTree> btreeFactory;
private final BloomFilterFactory bloomFilterFactory;
- private final ILSMComponentFilterFactory filterFactory;
+ private final IComponentFilterFactoryAndComparatorFactoriesProvider
filterFactory;
public LSMInvertedIndexDiskComponentFactory(OnDiskInvertedIndexFactory
diskInvIndexFactory,
TreeIndexFactory<BTree> btreeFactory, BloomFilterFactory
bloomFilterFactory,
- ILSMComponentFilterFactory filterFactory) {
+ IComponentFilterFactoryAndComparatorFactoriesProvider
filterFactory) {
this.diskInvIndexFactory = diskInvIndexFactory;
this.btreeFactory = btreeFactory;
this.bloomFilterFactory = bloomFilterFactory;
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/PartitionedLSMInvertedIndex.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/PartitionedLSMInvertedIndex.java
index 8cd45dc..9909ff6 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/PartitionedLSMInvertedIndex.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/PartitionedLSMInvertedIndex.java
@@ -26,7 +26,7 @@
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.io.IIOManager;
import org.apache.hyracks.storage.am.bloomfilter.impls.BloomFilterFactory;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFactory;
+import
org.apache.hyracks.storage.am.lsm.common.api.IComponentFilterFactoryAndComparatorFactoriesProvider;
import
org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFrameFactory;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMIOOperationCallback;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMIOOperationScheduler;
@@ -47,7 +47,7 @@
public PartitionedLSMInvertedIndex(IIOManager ioManager,
List<IVirtualBufferCache> virtualBufferCaches,
OnDiskInvertedIndexFactory diskInvIndexFactory, BTreeFactory
deletedKeysBTreeFactory,
- BloomFilterFactory bloomFilterFactory, ILSMComponentFilterFactory
filterFactory,
+ BloomFilterFactory bloomFilterFactory,
IComponentFilterFactoryAndComparatorFactoriesProvider filterFactory,
ILSMComponentFilterFrameFactory filterFrameFactory,
LSMComponentFilterManager filterManager,
double bloomFilterFalsePositiveRate, ILSMIndexFileManager
fileManager, IFileMapProvider diskFileMapProvider,
ITypeTraits[] invListTypeTraits, IBinaryComparatorFactory[]
invListCmpFactories,
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/util/InvertedIndexUtils.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/util/InvertedIndexUtils.java
index 075cded..f35fc28 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/util/InvertedIndexUtils.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/util/InvertedIndexUtils.java
@@ -42,7 +42,7 @@
import org.apache.hyracks.storage.am.lsm.common.api.IVirtualBufferCache;
import
org.apache.hyracks.storage.am.lsm.common.frames.LSMComponentFilterFrameFactory;
import org.apache.hyracks.storage.am.lsm.common.impls.BTreeFactory;
-import
org.apache.hyracks.storage.am.lsm.common.impls.LSMComponentFilterFactory;
+import
org.apache.hyracks.storage.am.lsm.common.impls.ComponentFilterFactoryAndComparatorFactoriesProvider;
import
org.apache.hyracks.storage.am.lsm.common.impls.LSMComponentFilterManager;
import
org.apache.hyracks.storage.am.lsm.invertedindex.api.IInvertedListBuilder;
import
org.apache.hyracks.storage.am.lsm.invertedindex.api.IInvertedListBuilderFactory;
@@ -152,12 +152,13 @@
diskFileMapProvider, invListBuilderFactory, invListTypeTraits,
invListCmpFactories, tokenTypeTraits,
tokenCmpFactories, fileManager, pageManagerFactory);
- LSMComponentFilterFactory filterFactory = null;
+ ComponentFilterFactoryAndComparatorFactoriesProvider filterFactory =
null;
LSMComponentFilterFrameFactory filterFrameFactory = null;
LSMComponentFilterManager filterManager = null;
if (filterCmpFactories != null) {
TypeAwareTupleWriterFactory filterTupleWriterFactory = new
TypeAwareTupleWriterFactory(filterTypeTraits);
- filterFactory = new
LSMComponentFilterFactory(filterTupleWriterFactory, filterCmpFactories);
+ filterFactory = new
ComponentFilterFactoryAndComparatorFactoriesProvider(filterTupleWriterFactory,
+ filterCmpFactories);
filterFrameFactory = new
LSMComponentFilterFrameFactory(filterTupleWriterFactory);
filterManager = new LSMComponentFilterManager(filterFrameFactory);
}
@@ -201,12 +202,13 @@
diskBufferCache, diskFileMapProvider, invListBuilderFactory,
invListTypeTraits, invListCmpFactories,
tokenTypeTraits, tokenCmpFactories, fileManager,
pageManagerFactory);
- LSMComponentFilterFactory filterFactory = null;
+ ComponentFilterFactoryAndComparatorFactoriesProvider filterFactory =
null;
LSMComponentFilterFrameFactory filterFrameFactory = null;
LSMComponentFilterManager filterManager = null;
if (filterCmpFactories != null) {
TypeAwareTupleWriterFactory filterTupleWriterFactory = new
TypeAwareTupleWriterFactory(filterTypeTraits);
- filterFactory = new
LSMComponentFilterFactory(filterTupleWriterFactory, filterCmpFactories);
+ filterFactory = new
ComponentFilterFactoryAndComparatorFactoriesProvider(filterTupleWriterFactory,
+ filterCmpFactories);
filterFrameFactory = new
LSMComponentFilterFrameFactory(filterTupleWriterFactory);
filterManager = new LSMComponentFilterManager(filterFrameFactory);
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java
index a9eca4d..8537479 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java
@@ -34,7 +34,7 @@
import org.apache.hyracks.storage.am.common.api.ITreeIndex;
import org.apache.hyracks.storage.am.common.api.ITreeIndexFrameFactory;
import org.apache.hyracks.storage.am.common.ophelpers.IndexOperation;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFactory;
+import
org.apache.hyracks.storage.am.lsm.common.api.IComponentFilterFactoryAndComparatorFactoriesProvider;
import
org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFrameFactory;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponent;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponentFactory;
@@ -86,7 +86,7 @@
IBinaryComparatorFactory[] btreeCmpFactories,
ILinearizeComparatorFactory linearizer,
int[] comparatorFields, IBinaryComparatorFactory[]
linearizerArray, double bloomFilterFalsePositiveRate,
ILSMMergePolicy mergePolicy, ILSMOperationTracker opTracker,
ILSMIOOperationScheduler ioScheduler,
- ILSMIOOperationCallback ioOpCallback, ILSMComponentFilterFactory
filterFactory,
+ ILSMIOOperationCallback ioOpCallback,
IComponentFilterFactoryAndComparatorFactoriesProvider filterFactory,
ILSMComponentFilterFrameFactory filterFrameFactory,
LSMComponentFilterManager filterManager,
int[] rtreeFields, int[] filterFields, boolean durable, boolean
isPointMBR, IBufferCache diskBufferCache)
throws HyracksDataException {
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTree.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTree.java
index 640b311..8fc551b 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTree.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTree.java
@@ -45,8 +45,8 @@
import org.apache.hyracks.storage.am.common.impls.NoOpOperationCallback;
import org.apache.hyracks.storage.am.common.ophelpers.IndexOperation;
import org.apache.hyracks.storage.am.common.tuples.DualTupleReference;
+import
org.apache.hyracks.storage.am.lsm.common.api.IComponentFilterFactoryAndComparatorFactoriesProvider;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponent;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFactory;
import
org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFrameFactory;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponent;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMIOOperation;
@@ -81,14 +81,14 @@
ITreeIndexFrameFactory btreeInteriorFrameFactory,
ITreeIndexFrameFactory btreeLeafFrameFactory,
ILSMIndexFileManager fileNameManager, TreeIndexFactory<RTree>
diskRTreeFactory,
TreeIndexFactory<BTree> diskBTreeFactory, BloomFilterFactory
bloomFilterFactory,
- ILSMComponentFilterFactory filterFactory,
ILSMComponentFilterFrameFactory filterFrameFactory,
- LSMComponentFilterManager filterManager, double
bloomFilterFalsePositiveRate,
- IFileMapProvider diskFileMapProvider, int fieldCount,
IBinaryComparatorFactory[] rtreeCmpFactories,
- IBinaryComparatorFactory[] btreeCmpFactories,
ILinearizeComparatorFactory linearizer,
- int[] comparatorFields, IBinaryComparatorFactory[]
linearizerArray, ILSMMergePolicy mergePolicy,
- ILSMOperationTracker opTracker, ILSMIOOperationScheduler
ioScheduler, ILSMIOOperationCallback ioOpCallback,
- int[] rtreeFields, int[] buddyBTreeFields, int[] filterFields,
boolean durable, boolean isPointMBR)
- throws HyracksDataException {
+ IComponentFilterFactoryAndComparatorFactoriesProvider
filterFactory,
+ ILSMComponentFilterFrameFactory filterFrameFactory,
LSMComponentFilterManager filterManager,
+ double bloomFilterFalsePositiveRate, IFileMapProvider
diskFileMapProvider, int fieldCount,
+ IBinaryComparatorFactory[] rtreeCmpFactories,
IBinaryComparatorFactory[] btreeCmpFactories,
+ ILinearizeComparatorFactory linearizer, int[] comparatorFields,
IBinaryComparatorFactory[] linearizerArray,
+ ILSMMergePolicy mergePolicy, ILSMOperationTracker opTracker,
ILSMIOOperationScheduler ioScheduler,
+ ILSMIOOperationCallback ioOpCallback, int[] rtreeFields, int[]
buddyBTreeFields, int[] filterFields,
+ boolean durable, boolean isPointMBR) throws HyracksDataException {
super(ioManager, virtualBufferCaches, rtreeInteriorFrameFactory,
rtreeLeafFrameFactory,
btreeInteriorFrameFactory, btreeLeafFrameFactory,
fileNameManager,
new LSMRTreeDiskComponentFactory(diskRTreeFactory,
diskBTreeFactory, bloomFilterFactory, filterFactory),
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeDiskComponentFactory.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeDiskComponentFactory.java
index 2e457d9..fadf8dd 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeDiskComponentFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeDiskComponentFactory.java
@@ -22,7 +22,7 @@
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.storage.am.bloomfilter.impls.BloomFilterFactory;
import org.apache.hyracks.storage.am.btree.impls.BTree;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFactory;
+import
org.apache.hyracks.storage.am.lsm.common.api.IComponentFilterFactoryAndComparatorFactoriesProvider;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponentFactory;
import
org.apache.hyracks.storage.am.lsm.common.impls.LSMComponentFileReferences;
import org.apache.hyracks.storage.am.lsm.common.impls.TreeIndexFactory;
@@ -32,10 +32,10 @@
private final TreeIndexFactory<RTree> rtreeFactory;
private final TreeIndexFactory<BTree> btreeFactory;
private final BloomFilterFactory bloomFilterFactory;
- private final ILSMComponentFilterFactory filterFactory;
+ private final IComponentFilterFactoryAndComparatorFactoriesProvider
filterFactory;
public LSMRTreeDiskComponentFactory(TreeIndexFactory<RTree> rtreeFactory,
TreeIndexFactory<BTree> btreeFactory,
- BloomFilterFactory bloomFilterFactory, ILSMComponentFilterFactory
filterFactory) {
+ BloomFilterFactory bloomFilterFactory,
IComponentFilterFactoryAndComparatorFactoriesProvider filterFactory) {
this.rtreeFactory = rtreeFactory;
this.btreeFactory = btreeFactory;
this.bloomFilterFactory = bloomFilterFactory;
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuples.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuples.java
index bb85696..bacbbd6 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuples.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuples.java
@@ -36,8 +36,8 @@
import org.apache.hyracks.storage.am.common.api.ITreeIndexFrameFactory;
import org.apache.hyracks.storage.am.common.impls.NoOpOperationCallback;
import org.apache.hyracks.storage.am.common.tuples.PermutingTupleReference;
+import
org.apache.hyracks.storage.am.lsm.common.api.IComponentFilterFactoryAndComparatorFactoriesProvider;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponent;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFactory;
import
org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFrameFactory;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponent;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponentFactory;
@@ -82,7 +82,8 @@
ITreeIndexFrameFactory rtreeInteriorFrameFactory,
ITreeIndexFrameFactory rtreeLeafFrameFactory,
ITreeIndexFrameFactory btreeInteriorFrameFactory,
ITreeIndexFrameFactory btreeLeafFrameFactory,
ILSMIndexFileManager fileManager, TreeIndexFactory<RTree>
diskRTreeFactory,
- TreeIndexFactory<RTree> bulkLoadRTreeFactory,
ILSMComponentFilterFactory filterFactory,
+ TreeIndexFactory<RTree> bulkLoadRTreeFactory,
+ IComponentFilterFactoryAndComparatorFactoriesProvider
filterFactory,
ILSMComponentFilterFrameFactory filterFrameFactory,
LSMComponentFilterManager filterManager,
IFileMapProvider diskFileMapProvider, int fieldCount,
IBinaryComparatorFactory[] rtreeCmpFactories,
IBinaryComparatorFactory[] btreeComparatorFactories,
ILinearizeComparatorFactory linearizer,
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesDiskComponentFactory.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesDiskComponentFactory.java
index f1af5a1..7355d86 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesDiskComponentFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesDiskComponentFactory.java
@@ -20,7 +20,7 @@
package org.apache.hyracks.storage.am.lsm.rtree.impls;
import org.apache.hyracks.api.exceptions.HyracksDataException;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMComponentFilterFactory;
+import
org.apache.hyracks.storage.am.lsm.common.api.IComponentFilterFactoryAndComparatorFactoriesProvider;
import org.apache.hyracks.storage.am.lsm.common.api.ILSMDiskComponentFactory;
import
org.apache.hyracks.storage.am.lsm.common.impls.LSMComponentFileReferences;
import org.apache.hyracks.storage.am.lsm.common.impls.TreeIndexFactory;
@@ -28,10 +28,10 @@
public class LSMRTreeWithAntiMatterTuplesDiskComponentFactory implements
ILSMDiskComponentFactory {
private final TreeIndexFactory<RTree> rtreeFactory;
- private final ILSMComponentFilterFactory filterFactory;
+ private final IComponentFilterFactoryAndComparatorFactoriesProvider
filterFactory;
public
LSMRTreeWithAntiMatterTuplesDiskComponentFactory(TreeIndexFactory<RTree>
rtreeFactory,
- ILSMComponentFilterFactory filterFactory) {
+ IComponentFilterFactoryAndComparatorFactoriesProvider
filterFactory) {
this.rtreeFactory = rtreeFactory;
this.filterFactory = filterFactory;
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/utils/LSMRTreeUtils.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/utils/LSMRTreeUtils.java
index e702d59..a2f581d 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/utils/LSMRTreeUtils.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/utils/LSMRTreeUtils.java
@@ -47,7 +47,7 @@
import org.apache.hyracks.storage.am.lsm.common.api.IVirtualBufferCache;
import
org.apache.hyracks.storage.am.lsm.common.frames.LSMComponentFilterFrameFactory;
import org.apache.hyracks.storage.am.lsm.common.impls.BTreeFactory;
-import
org.apache.hyracks.storage.am.lsm.common.impls.LSMComponentFilterFactory;
+import
org.apache.hyracks.storage.am.lsm.common.impls.ComponentFilterFactoryAndComparatorFactoriesProvider;
import
org.apache.hyracks.storage.am.lsm.common.impls.LSMComponentFilterManager;
import org.apache.hyracks.storage.am.lsm.common.impls.TreeIndexFactory;
import org.apache.hyracks.storage.am.lsm.rtree.impls.ExternalRTree;
@@ -121,12 +121,13 @@
BloomFilterFactory bloomFilterFactory =
new BloomFilterFactory(diskBufferCache, diskFileMapProvider,
bloomFilterKeyFields);
- LSMComponentFilterFactory filterFactory = null;
+ ComponentFilterFactoryAndComparatorFactoriesProvider filterFactory =
null;
LSMComponentFilterFrameFactory filterFrameFactory = null;
LSMComponentFilterManager filterManager = null;
if (filterCmpFactories != null) {
TypeAwareTupleWriterFactory filterTupleWriterFactory = new
TypeAwareTupleWriterFactory(filterTypeTraits);
- filterFactory = new
LSMComponentFilterFactory(filterTupleWriterFactory, filterCmpFactories);
+ filterFactory = new
ComponentFilterFactoryAndComparatorFactoriesProvider(filterTupleWriterFactory,
+ filterCmpFactories);
filterFrameFactory = new
LSMComponentFilterFrameFactory(filterTupleWriterFactory);
filterManager = new LSMComponentFilterManager(filterFrameFactory);
}
@@ -204,12 +205,13 @@
j++;
}
- LSMComponentFilterFactory filterFactory = null;
+ ComponentFilterFactoryAndComparatorFactoriesProvider filterFactory =
null;
LSMComponentFilterFrameFactory filterFrameFactory = null;
LSMComponentFilterManager filterManager = null;
if (filterCmpFactories != null) {
TypeAwareTupleWriterFactory filterTupleWriterFactory = new
TypeAwareTupleWriterFactory(filterTypeTraits);
- filterFactory = new
LSMComponentFilterFactory(filterTupleWriterFactory, filterCmpFactories);
+ filterFactory = new
ComponentFilterFactoryAndComparatorFactoriesProvider(filterTupleWriterFactory,
+ filterCmpFactories);
filterFrameFactory = new
LSMComponentFilterFrameFactory(filterTupleWriterFactory);
filterManager = new LSMComponentFilterManager(filterFrameFactory);
}
@@ -218,9 +220,9 @@
LSMRTreeWithAntiMatterTuples lsmTree = new
LSMRTreeWithAntiMatterTuples(ioManager, virtualBufferCaches,
rtreeInteriorFrameFactory, rtreeLeafFrameFactory,
btreeInteriorFrameFactory, btreeLeafFrameFactory,
fileNameManager, diskRTreeFactory, bulkLoadRTreeFactory,
filterFactory, filterFrameFactory,
- filterManager, diskFileMapProvider, typeTraits.length,
rtreeCmpFactories,
- btreeComparatorFactories, linearizerCmpFactory,
comparatorFields, linearizerArray, mergePolicy,
- opTracker, ioScheduler, ioOpCallback, rtreeFields,
filterFields, durable, isPointMBR);
+ filterManager, diskFileMapProvider, typeTraits.length,
rtreeCmpFactories, btreeComparatorFactories,
+ linearizerCmpFactory, comparatorFields, linearizerArray,
mergePolicy, opTracker, ioScheduler,
+ ioOpCallback, rtreeFields, filterFields, durable, isPointMBR);
return lsmTree;
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/1779
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b3d9bef3fb6118c66195630cec23a7e41fc5861
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>