Michael Blow has posted comments on this change. Change subject: Add a dataset rebalance REST API. ......................................................................
Patch Set 10: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1768/10/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/DatasetIdFactory.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/DatasetIdFactory.java: PS10, Line 39: id.compareAndSet(Integer.MAX_VALUE, startId); > throw exception instead if it reached max. otherwise, this could lead to ca and then what? we need to recycle these somehow, right? PS10, Line 43: public static int generateAlternatingDatasetId(int originalId) { : return originalId ^ 0x80000000; : } > this is just * -1 ? if so, why not change it? I don't think it is the most Not *= -1. 0*-1 = 0 -- To view, visit https://asterix-gerrit.ics.uci.edu/1768 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda35252031fc4940972f0f19bbf796cadfa53d6 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
