Luo Chen has posted comments on this change. Change subject: Add LSMDiskComponentBulkLoader ......................................................................
Patch Set 4: > IIndexBulkLoader is exactly the same as ILSMDiskComponentBuilLoader. > why add a new interface and not use the existing one? There are similar, since currently the LSM index bulk load operation would also create one disk component. But here are a few differences: - In LSMDiskComponentBulkLoader, the component is created outside it, which gives the caller more freedom and makes it suitable for flush/merge/index bulk load operations. - The end() method of LSMDiskComponentBulkLoader does not put the component into the component list of the index immediately (while the index bulk loader does), and the caller has the freedom to handle the result component. - Its sub interface ILSMDiskComponentWithBuddyBTreeBulkLoader has a method called addDeletedTuple, which allows the caller to bulk load the buddy btree. - When we need to create a disk component (for flush/merge/index bulk load/create secondary index), the new interfaces allows us to only deal with two kinds of disk components (with anti-matter tuples/with buddy btree), instead of writing difference code for different lsm indexes. -- To view, visit https://asterix-gerrit.ics.uci.edu/1773 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I772a6d68761fcbb85982a1c9f72f2d186e1d1ffb Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
