Till Westmann has posted comments on this change. Change subject: Add a dataset rebalance REST API. ......................................................................
Patch Set 15: (8 comments) Looks good, only tiny comments/questions. https://asterix-gerrit.ics.uci.edu/#/c/1768/15/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RebalanceApiServlet.java: PS15, Line 65: TEXT_HTML Why HTML and not JSON? https://asterix-gerrit.ics.uci.edu/#/c/1768/15/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RebalanceTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/RebalanceTest.java: PS15, Line 3: * * Licensed to the Apache Software Foundation (ASF) under one Double comments. https://asterix-gerrit.ics.uci.edu/#/c/1768/15/asterixdb/asterix-app/src/test/resources/runtimets/rebalance.xml File asterixdb/asterix-app/src/test/resources/runtimets/rebalance.xml: PS15, Line 4: ~ * s/ ~ * Licensed/ ! Licensed/ https://asterix-gerrit.ics.uci.edu/#/c/1768/15/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java: PS15, Line 35: rebalance s#/rebalance#/admin/rebalance# or something similar? https://asterix-gerrit.ics.uci.edu/#/c/1768/15/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryInvertedIndexOperationsHelper.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryInvertedIndexOperationsHelper.java: PS15, Line 214: IOperatorDescriptor keyProviderOp = DatasetUtil.createDummyKeyProviderOp(spec, dataset, : metadataProvider); single line? PS15, Line 218: IOperatorDescriptor primaryScanOp = DatasetUtil.createPrimaryIndexScanOp(spec, metadataProvider, dataset, : jobId); single line? https://asterix-gerrit.ics.uci.edu/#/c/1768/15/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryRTreeOperationsHelper.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryRTreeOperationsHelper.java: PS15, Line 205: IOperatorDescriptor keyProviderOp = DatasetUtil.createDummyKeyProviderOp(spec, dataset, : metadataProvider); single line? https://asterix-gerrit.ics.uci.edu/#/c/1768/15/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java: PS15, Line 91: RESOURCE_NOT_EXIST s/RESOURCE_NOT_EXIST/RESOURCE_DOES_NOT_EXIST/? -- To view, visit https://asterix-gerrit.ics.uci.edu/1768 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibda35252031fc4940972f0f19bbf796cadfa53d6 Gerrit-PatchSet: 15 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
