Luo Chen has posted comments on this change. Change subject: Add LSMDiskComponentBulkLoader ......................................................................
Patch Set 7: > Chen Luo, > I don't think the differences are fundamental enough to warrant > creating a new interface. can we keep using the IIndexBulkLoader > instead of the ILSMDiskComponentBulkLoader? We can keep the > ILSMDiskComponentWithBuddyBTreeBulkLoader which would extend the > IIndexBulkLoader. everything else should stay the same IMO. > > Thoughts? It's OK to me. I'll make necessary changes and submit a new patch tomorrow. -- To view, visit https://asterix-gerrit.ics.uci.edu/1773 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I772a6d68761fcbb85982a1c9f72f2d186e1d1ffb Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
