Murtadha Hubail has posted comments on this change. Change subject: Enable Adding Nodes to Running *DB Cluster ......................................................................
Patch Set 6: (2 comments) Just a question that might be outside the scope of this change. After stopping the running instance and starting it again, will you have to start the newly added nodes manually again? https://asterix-gerrit.ics.uci.edu/#/c/1785/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/PropertiesAccessor.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/PropertiesAccessor.java: PS6, Line 246: uniquePartitionId Wouldn't you want to check for overlapping partition id configuration (i.e. starting with an ID that was already used by an active NC) or is this some sort of flexibility to allow replacing partitions of an existing node? https://asterix-gerrit.ics.uci.edu/#/c/1785/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java: PS6, Line 355: registerNodePartitions Is this method used anywhere? -- To view, visit https://asterix-gerrit.ics.uci.edu/1785 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If978442a95687c00ef78c89ed1b4440f5e308b99 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
