Luo Chen has posted comments on this change. Change subject: Implemented Disk Components Alignment Based on IDs ......................................................................
Patch Set 11: (1 comment) > (2 comments) > > a very small comment. and the old comment I thought I posted > before. > This is very nice work (+1). will +2 once the comment is addressed https://asterix-gerrit.ics.uci.edu/#/c/1761/10/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/IndexInfo.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/IndexInfo.java: PS10, Line 26: resourceId > why rename this? seems like we are moving towards having Id instead of ID : This is changed by accident... I reverted back. -- To view, visit https://asterix-gerrit.ics.uci.edu/1761 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I768ee9ac0a8d3c99c631086093a6b778b2e7588e Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
