Luo Chen has posted comments on this change. Change subject: Add LSMDiskComponentBulkLoader ......................................................................
Patch Set 12: > (1 comment) Hi, I submitted a new patch to remove the hasBloomFilter parameter. However, to be consistent with the current behavior, the component bulk loader creates the bloom filter only when numElementsHint>0 (numElements has to be known in advance in order to create the bloom filter, otherwise, it implies the bloom filter is not needed). -- To view, visit https://asterix-gerrit.ics.uci.edu/1773 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I772a6d68761fcbb85982a1c9f72f2d186e1d1ffb Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
