Yingyi Bu has posted comments on this change. Change subject: Change logical plan to apply filter from 2ndary index ......................................................................
Patch Set 15: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1727/15/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java: PS15, Line 166: ArrayList ArrayList -> List https://asterix-gerrit.ics.uci.edu/#/c/1727/15/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/IntersectOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/IntersectOperator.java: PS15, Line 126: public void setExtraVariables(List<List<LogicalVariable>> extraVars, List<LogicalVariable> extraOutputVars) { : this.extraVars = extraVars; : for (int i = 0; i < extraVars.size(); i++) { : this.inputVars.get(i).addAll(extraVars.get(i)); : } : this.outputVars.addAll(extraOutputVars); : } Can we eliminate the setter and instead, add a constructor with these two additional parameters? https://asterix-gerrit.ics.uci.edu/#/c/1727/15/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/intersect/IntersectOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/intersect/IntersectOperatorDescriptor.java: PS15, Line 109: throw new HyracksException("The given input extra fields is not equal"); Error code? -- To view, visit https://asterix-gerrit.ics.uci.edu/1727 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e2fe0208662e5dcd49d1a22bfb58f96533e9497 Gerrit-PatchSet: 15 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
