Luo Chen has posted comments on this change.

Change subject: Log filter values for redo during recovery
......................................................................


Patch Set 5:

(58 comments)

The patch is straightforward to me. Mainly some format issues (whitespace) for 
test queries, and one tricky difference between BTree and RTree/InvertedIndex.

https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.1.script.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.1.script.aql:

Line 19: create_and_start.sh
Do we need to change the name of *.aql to match its parent folder?


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.2.ddl.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.2.ddl.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


PS5, Line 52: /* Create dataset for loading raw Fragile data */
            : create dataset Fragile_raw (FragileTypeRaw)
            : primary key row_id;
            : 
            : /* Create dataset for cleaned Fragile data */
            : create dataset Fragile (FragileType)
            : primary key row_id with filter on date;
Is it possible to use a file feed to directly feed data into the dataset 
(instead of load first, and then insert)?


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.3.update.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.3.update.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.4.txneu.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.4.txneu.aql:

PS5, Line 19:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.5.txnqbc.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.5.txnqbc.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.8.txnqar.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_index_only_filtered/primary_index_only.8.txnqar.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_secondary_index_filtered/primary_plus_default_secondary_index.2.ddl.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_secondary_index_filtered/primary_plus_default_secondary_index.2.ddl.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_secondary_index_filtered/primary_plus_default_secondary_index.3.update.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_secondary_index_filtered/primary_plus_default_secondary_index.3.update.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_secondary_index_filtered/primary_plus_default_secondary_index.4.txneu.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_secondary_index_filtered/primary_plus_default_secondary_index.4.txneu.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_secondary_index_filtered/primary_plus_default_secondary_index.5.txnqbc.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_secondary_index_filtered/primary_plus_default_secondary_index.5.txnqbc.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_secondary_index_filtered/primary_plus_default_secondary_index.8.txnqar.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_default_secondary_index_filtered/primary_plus_default_secondary_index.8.txnqar.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_secondary_index_filtered/primary_plus_keyword_secondary_index.2.ddl.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_secondary_index_filtered/primary_plus_keyword_secondary_index.2.ddl.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


PS5, Line 43:   
Whitespace


PS5, Line 55:   
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_secondary_index_filtered/primary_plus_keyword_secondary_index.3.update.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_secondary_index_filtered/primary_plus_keyword_secondary_index.3.update.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_secondary_index_filtered/primary_plus_keyword_secondary_index.4.txneu.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_secondary_index_filtered/primary_plus_keyword_secondary_index.4.txneu.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_secondary_index_filtered/primary_plus_keyword_secondary_index.5.txnqbc.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_secondary_index_filtered/primary_plus_keyword_secondary_index.5.txnqbc.aql:

PS5, Line 21:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_secondary_index_filtered/primary_plus_keyword_secondary_index.8.txnqar.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_keyword_secondary_index_filtered/primary_plus_keyword_secondary_index.8.txnqar.aql:

PS5, Line 21:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_multiple_secondary_indices_filtered/primary_plus_multiple_secondary_indices.2.ddl.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_multiple_secondary_indices_filtered/primary_plus_multiple_secondary_indices.2.ddl.aql:

PS5, Line 19:  
Whitespace


PS5, Line 43:   
Whitespace


PS5, Line 55:   
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_multiple_secondary_indices_filtered/primary_plus_multiple_secondary_indices.3.update.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_multiple_secondary_indices_filtered/primary_plus_multiple_secondary_indices.3.update.aql:

PS5, Line 19:  
Whitespace


PS5, Line 21:    
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_multiple_secondary_indices_filtered/primary_plus_multiple_secondary_indices.4.txneu.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_multiple_secondary_indices_filtered/primary_plus_multiple_secondary_indices.4.txneu.aql:

PS5, Line 19:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_multiple_secondary_indices_filtered/primary_plus_multiple_secondary_indices.5.txnqbc.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_multiple_secondary_indices_filtered/primary_plus_multiple_secondary_indices.5.txnqbc.aql:

PS5, Line 19:  
Whitespace


PS5, Line 29:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_multiple_secondary_indices_filtered/primary_plus_multiple_secondary_indices.8.txnqar.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_multiple_secondary_indices_filtered/primary_plus_multiple_secondary_indices.8.txnqar.aql:

PS5, Line 22:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_ngram_index_filtered/primary_plus_ngram_index.2.ddl.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_ngram_index_filtered/primary_plus_ngram_index.2.ddl.aql:

PS5, Line 19:  
Whitespace


PS5, Line 54:   
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_ngram_index_filtered/primary_plus_ngram_index.3.update.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_ngram_index_filtered/primary_plus_ngram_index.3.update.aql:

PS5, Line 19:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_ngram_index_filtered/primary_plus_ngram_index.4.txneu.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_ngram_index_filtered/primary_plus_ngram_index.4.txneu.aql:

PS5, Line 19:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_ngram_index_filtered/primary_plus_ngram_index.5.txnqbc.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_ngram_index_filtered/primary_plus_ngram_index.5.txnqbc.aql:

PS5, Line 19:  
Whitespace


Line 28: count (for $x in dataset Fragile 
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_ngram_index_filtered/primary_plus_ngram_index.8.txnqar.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_ngram_index_filtered/primary_plus_ngram_index.8.txnqar.aql:

PS5, Line 19:  
Whitespace


PS5, Line 28:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_rtree_index_filtered/primary_plus_rtree_index.2.ddl.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_rtree_index_filtered/primary_plus_rtree_index.2.ddl.aql:

PS5, Line 19:  
Whitespace


PS5, Line 43:   
Whitespace


PS5, Line 55:   
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_rtree_index_filtered/primary_plus_rtree_index.3.update.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_rtree_index_filtered/primary_plus_rtree_index.3.update.aql:

PS5, Line 19:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_rtree_index_filtered/primary_plus_rtree_index.4.txneu.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_rtree_index_filtered/primary_plus_rtree_index.4.txneu.aql:

PS5, Line 19:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_rtree_index_filtered/primary_plus_rtree_index.5.txnqbc.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_rtree_index_filtered/primary_plus_rtree_index.5.txnqbc.aql:

PS5, Line 21:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_rtree_index_filtered/primary_plus_rtree_index.8.txnqar.aql
File 
asterixdb/asterix-installer/src/test/resources/transactionts/queries/recover_after_abort/primary_plus_rtree_index_filtered/primary_plus_rtree_index.8.txnqar.aql:

PS5, Line 21:  
Whitespace


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTree.java:

PS5, Line 752: BTreeOpContext
This function will not be used then?


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java:

PS5, Line 232: ctx
why there is a before/found call here?
I think I didn't see that for BTree...


https://asterix-gerrit.ics.uci.edu/#/c/1798/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java:

PS5, Line 243: ctx.getModificationCallback().before(indexTuple);
             :         ctx.getModificationCallback().found(null, tuple);
Same here for RTree. It seems there is some difference between BTree and 
RTree/InvertedIndex?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1798
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Jianfeng Jia <[email protected]>
Gerrit-Reviewer: Luo Chen <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-HasComments: Yes

Reply via email to