Michael Blow has posted comments on this change.

Change subject: ASTERIXDB-1130: Replace Java serialization for persisted objects
......................................................................


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1807/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java:

PS2, Line 169:             //Using static method
             :             Method method = clazz.getMethod("fromJson", 
IPersistedResourceRegistry.class, byte[].class);
             :             return (IJsonSerializable) method.invoke(null, this, 
json);
What is the problem when using the Jackson mapper?  In my experience, it has 
worked pretty well (and probably can eliminate a lot of the boilerplate 
fromJson() methods...?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1807
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I833b7e236305a3693acaea930947f7f83c8ed1fa
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-HasComments: Yes

Reply via email to