Luo Chen has posted comments on this change. Change subject: Avoid always merging old components in prefix policy ......................................................................
Patch Set 5: (4 comments) > (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/1818/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/PrefixMergePolicy.java: PS5, Line 47: take > taken Done PS5, Line 270: @return > complete the java doc Done PS5, Line 275: immutableComponents.get(i).getState() != ComponentState.READABLE_UNWRITABLE > This probably won't happen because this method is called from a synchronize This method is called by both isMergeLagging and diskComponentAdded. In isMergeLagging, this is possible since it is called by a flush thread, while some disk components are being flushed. In diskComponentAdded, this shouldn't happen, since if some components are being merged, we would ignore this round of merge. PS5, Line 284: immutableComponents.get(j).getState() != ComponentState.READABLE_UNWRITABL > This probably won't happen because this method is called from a synchronize Same as above. -- To view, visit https://asterix-gerrit.ics.uci.edu/1818 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I464da3fed38cded0aee7b319a35664eae069a2ba Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
