Michael Blow has posted comments on this change. Change subject: Cancel the on-going job if waitForCompletion is interrupted. ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1825/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksConnection.java: PS3, Line 146: // Re-interrupts the current thread to make sure that consequent things get interrupted. I think you don't need to re-interrupt since you are propagating the InterruptedException. -- To view, visit https://asterix-gerrit.ics.uci.edu/1825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3417271660e815a13fd706e1cc057bca6a625c37 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
