Michael Blow has posted comments on this change. Change subject: Re-register NC with CC on reestablished IPCHandle ......................................................................
Patch Set 7: (8 comments) https://asterix-gerrit.ics.uci.edu/#/c/1830/7/asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/NCServiceExecutionIT.java File asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/NCServiceExecutionIT.java: PS7, Line 212: waitForCluster > Can we make this more generally accessible/reusable? Done Line 234: Thread.sleep(500); > MAJOR SonarQube violation: Done PS7, Line 268: waitForCluster > Move this before the nc.start()? Done https://asterix-gerrit.ics.uci.edu/#/c/1830/7/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/INCApplication.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/INCApplication.java: Line 36: void onRegisterNode() throws Exception; > CRITICAL SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1830/7/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/INodeControllerService.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/INodeControllerService.java: PS7, Line 23: INodeControllerService > Can we avoid this intermediate interface? Done https://asterix-gerrit.ics.uci.edu/#/c/1830/7/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java: PS7, Line 138: JobIdFactory > Empty line before? Done https://asterix-gerrit.ics.uci.edu/#/c/1830/7/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NodeRegistration.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NodeRegistration.java: PS7, Line 76: AtomicLong > Can we make this immutable? Done https://asterix-gerrit.ics.uci.edu/#/c/1830/7/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/src/main/java/org/apache/hyracks/control/nc/service/NCService.java: PS7, Line 177: ())); > Add nl? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1830 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f93ca9ab37e56e02bafcdecd1e2d0cf664faef6 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
