Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1371 - Define new datatype 'geometry' user model changes: Add new builtin type 'geometry' storage format changes: no interface changes: no ......................................................................
Patch Set 1: (5 comments) I think it looks like a good start. Comments: A test should have an output. Does this have a separate test-suite? If there will not many test cases for geoJSON, I think we don't create a separate test suite. https://asterix-gerrit.ics.uci.edu/#/c/1838/1/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/geojson/datatype/datatype_definition.1.ddl.sqlpp: PS1, Line 27: geometry Should this be allowed? I think the type name should be a reserved word. It's like declaring an "int : int". https://asterix-gerrit.ics.uci.edu/#/c/1838/1/asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.1.adm File asterixdb/asterix-app/src/test/resources/runtimets/results/geojson/datatype/datatype.1.adm: Line 1 Empty file? https://asterix-gerrit.ics.uci.edu/#/c/1838/1/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml: Line 22: <!ENTITY GeoQueries SYSTEM "queries_sqlpp/geojson/GeoJSONQueries.xml"> Not sure why this should be a separate test suite? PS1, Line 8788: Should be removed? https://asterix-gerrit.ics.uci.edu/#/c/1838/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/BuiltinType.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/BuiltinType.java: PS1, Line 708: type All other types are using their typetag here (captial). For example, check the line number 736. -- To view, visit https://asterix-gerrit.ics.uci.edu/1838 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If32dbfcc11350a81e6a64f6abeec0595aa7872d2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Riyafa Abdul Hameed <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
